Comments on: Code Reviews – A Positive Experience at Last http://mathieuberube.net/blog/2010/01/22/code-reviews_a_positive_experience_at_last/ Thoughts about programming, technology and agility Tue, 15 Nov 2011 02:58:49 +0000 hourly 1 http://wordpress.org/?v=3.2.1 By: mberube http://mathieuberube.net/blog/2010/01/22/code-reviews_a_positive_experience_at_last/comment-page-1/#comment-42 mberube Wed, 03 Feb 2010 03:28:49 +0000 http://mathieuberube.net/blog/?p=51#comment-42 Luc, I look forward to working with you again one day :) Since you're talking about the cost of a LOC, have you seen Uncle Bob's article <a href="http://blog.objectmentor.com/articles/2010/02/01/software-on-the-cheap" rel="nofollow">Software on the Cheap</a>? Luc, I look forward to working with you again one day :)

Since you’re talking about the cost of a LOC, have you seen Uncle Bob’s article Software on the Cheap?

]]> By: Luc Trudeau http://mathieuberube.net/blog/2010/01/22/code-reviews_a_positive_experience_at_last/comment-page-1/#comment-41 Luc Trudeau Wed, 03 Feb 2010 01:56:30 +0000 http://mathieuberube.net/blog/?p=51#comment-41 I strongly believe that code reviews should be incorporated into the software development process and count as work just like coding. Given the chance, I would love to try and put a trigger for every commit that would force a review before it gets added to the code base. This would ensure good quality code and 100% reviewed code. It's one of those idea that takes a lot of time but is worth it in the long run. Remember a KLOC is not cheap. I strongly believe that code reviews should be incorporated into the software development process and count as work just like coding.

Given the chance, I would love to try and put a trigger for every commit that would force a review before it gets added to the code base. This would ensure good quality code and 100% reviewed code.

It’s one of those idea that takes a lot of time but is worth it in the long run. Remember a KLOC is not cheap.

]]> By: mberube http://mathieuberube.net/blog/2010/01/22/code-reviews_a_positive_experience_at_last/comment-page-1/#comment-10 mberube Fri, 22 Jan 2010 13:32:18 +0000 http://mathieuberube.net/blog/?p=51#comment-10 Thanks to both Eric and Luc for pointing out pair programming. We considered it at the beginning of the project and came up with a few (lame) excuses for not doing it... the main point being that we had a very tight deadline for a trade show and we were ready (with our PO) to accumulate some debt to pump out more features. I think though that it really comes down to a matter of habits. I don't have an extensive pair programming experience so it's not a reflex yet. Under pressure, revert to your old (bad?) habits. As I said in the post, I'd appreciate a shorter feedback loop and pair programming might be the perfect answer. It's definitely a point i'd like to improve. Thanks to both Eric and Luc for pointing out pair programming. We considered it at the beginning of the project and came up with a few (lame) excuses for not doing it… the main point being that we had a very tight deadline for a trade show and we were ready (with our PO) to accumulate some debt to pump out more features.

I think though that it really comes down to a matter of habits. I don’t have an extensive pair programming experience so it’s not a reflex yet. Under pressure, revert to your old (bad?) habits. As I said in the post, I’d appreciate a shorter feedback loop and pair programming might be the perfect answer.

It’s definitely a point i’d like to improve.

]]> By: Eric Laramée http://mathieuberube.net/blog/2010/01/22/code-reviews_a_positive_experience_at_last/comment-page-1/#comment-9 Eric Laramée Fri, 22 Jan 2010 12:37:58 +0000 http://mathieuberube.net/blog/?p=51#comment-9 Great post! Any plans to move from code reviews to pair programming, or at least a balance between the two? Cheers! Great post!

Any plans to move from code reviews to pair programming, or at least a balance between the two?

Cheers!

]]> By: Luc Jeanniard http://mathieuberube.net/blog/2010/01/22/code-reviews_a_positive_experience_at_last/comment-page-1/#comment-8 Luc Jeanniard Fri, 22 Jan 2010 08:15:01 +0000 http://mathieuberube.net/blog/?p=51#comment-8 I agree with the benefits of code reviews you listed above. However, this kind of code review is, in my opinion, too late in the development process. Indeed, remarks may lead to big changes while we though the development was done (disappointing). When possible, I would encourage pair-programming as it gives immediate feedback on code quality. I agree with the benefits of code reviews you listed above. However, this kind of code review is, in my opinion, too late in the development process. Indeed, remarks may lead to big changes while we though the development was done (disappointing). When possible, I would encourage pair-programming as it gives immediate feedback on code quality.

]]>